[PATCH] drivers: serial: Fix dev_read_addr error check

Marek Vasut marek.vasut at mailbox.org
Tue May 26 00:51:12 CEST 2026


On 5/21/26 7:52 PM, Francois Berder wrote:
> dev_read_addr returns FDT_ADDR_T_NONE (-1) in case of error
> and not 0.
> 
> Signed-off-by: Francois Berder <fberder at outlook.fr>
> ---
>   drivers/serial/serial_sh.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/serial/serial_sh.c b/drivers/serial/serial_sh.c
> index bc205234e24..7debff6cb3a 100644
> --- a/drivers/serial/serial_sh.c
> +++ b/drivers/serial/serial_sh.c
> @@ -257,7 +257,7 @@ static int sh_serial_of_to_plat(struct udevice *dev)
>   	int ret;
>   
>   	addr = dev_read_addr(dev);
> -	if (!addr)
> +	if (addr == FDT_ADDR_T_NONE)
>   		return -EINVAL;
>   
>   	plat->base = addr;

The change itself looks valid, thank you.

I will give it a try on real hardware and then apply it for v2026.07 
sometimes next week.


More information about the U-Boot mailing list