[PATCH v4 0/2] Add regulator support to qcom-ufs driver

Casey Connolly casey.connolly at linaro.org
Tue May 26 16:01:39 CEST 2026


Hi Federico,

On 23/05/2026 15:04, Federico Amedeo Izzo via B4 Relay wrote:
> This series enables UFS support on SC7280 devices with UFS3.1.
> SC7280 devices with UFS2.2 were already working.
> 
> The root cause was ABL leaving vcc-supply regulator disabled on UFS3.1
> devices, and enabled on UFS2.2 devices that worked fine without
> regulator support.

Thanks a lot for working on this and finding the bug in the regulator
driver!

> 
> Signed-off-by: Federico Amedeo Izzo <federico at izzo.pro>

Reviewed-by: Casey Connolly <casey.connolly at linaro.org>

> ---
> Changes in v4:
> - Improve regulator mode fix: apply current mode during enable
> - Remove regulator mode code from qcom-ufs driver
> - Link to v3: https://patch.msgid.link/20260523-qcom-ufs-regulator-support-v3-0-1be2a80a2577@izzo.pro
> 
> Changes in v3:
> - Fix bug causing HPM mode not being applied. Removed LPM/HPM hack
> - Read regulator mode from dts property instead of hardcoding it
> - Link to v2: https://patch.msgid.link/20260521-qcom-ufs-regulator-support-v2-1-d3ec82ae5dbc@izzo.pro
> 
> Changes in v2:
> - Add vccq2-supply for UFS2.2 devices without internal eLDO regulator
> - Fix wrong topic
> - Link to v1: https://patch.msgid.link/20260521-dpu-add-dspp-gc-driver-v1-1-83372488cdcf@izzo.pro
> 
> To: Sumit Garg <sumit.garg at kernel.org>
> To: u-boot-qcom at groups.io
> To: u-boot at lists.denx.de
> Cc: Jaehoon Chung <jh80.chung at samsung.com>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Casey Connolly <casey.connolly at linaro.org>
> Cc: Neil Armstrong <neil.armstrong at linaro.org>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Luca Weiss <luca.weiss at fairphone.com>
> Cc: Aswin Murugan <aswin.murugan at oss.qualcomm.com>
> Cc: Federico Amedeo Izzo <federico at izzo.pro>
> Cc: Bhupesh Sharma <bhupesh.linux at gmail.com>
> Cc: Neha Malcom Francis <n-francis at ti.com>
> Cc: Julien Stephan <jstephan at baylibre.com>
> Cc: Marek Vasut <marek.vasut+renesas at mailbox.org>
> 
> ---
> Federico Amedeo Izzo (2):
>       regulator: qcom-rpmh-regulator: fix regulator mode mismatch
>       ufs: qcom: add ufs host regulator support
> 
>  drivers/power/regulator/qcom-rpmh-regulator.c | 106 ++++++++++++++------------
>  drivers/ufs/ufs-qcom.c                        |  25 ++++++
>  drivers/ufs/ufs-qcom.h                        |   4 +
>  3 files changed, 85 insertions(+), 50 deletions(-)
> ---
> base-commit: 744cf5d4e398c5f657e5c3eeb44d00fa5175dc85
> change-id: 20260521-qcom-ufs-regulator-support-466ea6ad202a
> 
> Best regards,
> --  
> Federico Amedeo Izzo <federico at izzo.pro>
> 
> 

-- 
// Casey (she/her)



More information about the U-Boot mailing list