[PATCH v1 1/1] treewide: prefer __func__ over __FUNCTION__ and __PRETTY_FUNCTION__

[Tom Rini]

On Tue, May 26, 2026 at 01:41:40AM +0000, Aristo Chen wrote:

> __FUNCTION__ and __PRETTY_FUNCTION__ are gcc extensions that predate
> the C99 __func__ identifier. scripts/checkpatch.pl emits a warning
> for any new use of __FUNCTION__ and recommends __func__ instead. In
> C (unlike C++) __PRETTY_FUNCTION__ is identical to __func__ because
> C function names do not carry signature information, so the
> distinction has no behavioural effect here. The majority of the tree
> already uses __func__, but a handful of older files in arch/, board/,
> boot/, drivers/, examples/ and include/ still carry the gcc spellings
> (55 occurrences of __FUNCTION__ across 19 files plus one
> __PRETTY_FUNCTION__ in drivers/usb/musb-new/omap2430.c). Convert
> them all to the C99 form so the tree is consistent and new patches
> in these areas do not have to follow an outdated local style.
> 
> Ten "Unnecessary ftrace-like logging - prefer using ftrace" warnings
> remain on the printf("%s\n", __func__) and dbg("%s\n", __func__)
> function-entry traces in drivers/net/rtl8169.c (behind DEBUG_RTL8169*
> preprocessor guards) and drivers/usb/host/ohci-hcd.c. checkpatch
> matches the literal "%s\n", __func__ shape regardless of the wrapper,
> so silencing those warnings would require changing the debug message
> text or removing the traces entirely.
> 
> Signed-off-by: Aristo Chen <aristo.chen at canonical.com>

Thanks for doing the cleanup here!

Reviewed-by: Tom Rini <trini at konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20260526/96bda794/attachment.sig>