[PATCH 2/3] watchdog: rti: Use dev_read_addr_ptr()
Stefan Roese
stefan.roese at mailbox.org
Wed May 27 14:31:54 CEST 2026
On 5/25/26 05:51, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan at nxp.com>
>
> devfdt_get_addr() returns FDT_ADDR_T_NONE(-1UL) when fail, using
> "!priv->regs" to check return value is wrong.
>
> Replace devfdt_read_addr() with dev_read_addr_ptr() when retrieving the
> register base address.
>
> dev_read_addr_ptr() supports both live device tree and flat DT backends,
> avoiding direct dependency on devfdt_* helpers.
>
> Also use "void __iomem *" to replace "phys_addr_t" to avoid type
> casting.
>
> No functional changes.
>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
Reviewed-by: Stefan Roese <stefan.roese at mailbox.org>
Thanks,
Stefan
> ---
> drivers/watchdog/rti_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
> index 7b387266b99..866f555789c 100644
> --- a/drivers/watchdog/rti_wdt.c
> +++ b/drivers/watchdog/rti_wdt.c
> @@ -39,7 +39,7 @@
> #define WDT_PRELOAD_MAX 0xfff
>
> struct rti_wdt_priv {
> - phys_addr_t regs;
> + void __iomem *regs;
> unsigned int clk_hz;
> };
>
> @@ -177,7 +177,7 @@ static int rti_wdt_probe(struct udevice *dev)
> struct clk clk;
> int ret;
>
> - priv->regs = devfdt_get_addr(dev);
> + priv->regs = dev_read_addr_ptr(dev);
> if (!priv->regs)
> return -EINVAL;
>
>
More information about the U-Boot
mailing list