[PATCH 09/13] virtio: Rename a few legacy-PCI functions

Heinrich Schuchardt xypron.glpk at gmx.de
Wed May 27 20:39:41 CEST 2026


On 5/27/26 18:10, Simon Glass wrote:
> With LSP it is confusing to have two functions named the same in
> different files. Rename a few of the legacy ones.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

LGTM

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

> ---
> 
>   drivers/virtio/virtio_pci_legacy.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c
> index 15f8c6e7d25..fe3e3b475ea 100644
> --- a/drivers/virtio/virtio_pci_legacy.c
> +++ b/drivers/virtio/virtio_pci_legacy.c
> @@ -277,7 +277,7 @@ static int virtio_pci_notify(struct udevice *udev, struct virtqueue *vq)
>   	return 0;
>   }
>   
> -static int virtio_pci_bind(struct udevice *udev)
> +static int virtio_pci_bind_legacy(struct udevice *udev)
>   {
>   	static unsigned int num_devs;
>   	char name[20];
> @@ -289,7 +289,7 @@ static int virtio_pci_bind(struct udevice *udev)
>   	return 0;
>   }
>   
> -static int virtio_pci_probe(struct udevice *udev)
> +static int virtio_pci_probe_legacy(struct udevice *udev)
>   {
>   	struct pci_child_plat *pplat = dev_get_parent_plat(udev);
>   	struct virtio_dev_priv *uc_priv = dev_get_uclass_priv(udev);
> @@ -348,8 +348,8 @@ U_BOOT_DRIVER(virtio_pci_legacy) = {
>   	.name	= VIRTIO_PCI_DRV_NAME,
>   	.id	= UCLASS_VIRTIO,
>   	.ops	= &virtio_pci_ops,
> -	.bind	= virtio_pci_bind,
> -	.probe	= virtio_pci_probe,
> +	.bind	= virtio_pci_bind_legacy,
> +	.probe	= virtio_pci_probe_legacy,
>   	.priv_auto	= sizeof(struct virtio_pci_priv),
>   };
>   



More information about the U-Boot mailing list