[PATCH v7 02/15] mbedtls: enable support of ecc

[Simon Glass]

Hi Philippe,

On 2026-05-28T08:19:01, Philippe Reynes <philippe.reynes at softathome.com> wrote:
> mbedtls: enable support of ecc
>
> Enables the support of ecc in mbedtls.
>
> Reviewed-by: Raymond Mao <raymondmaoca at gmail.com>
> Signed-off-by: Philippe Reynes <philippe.reynes at softathome.com>
>
> configs/sandbox_defconfig        |  1 +
>  lib/ecdsa/Kconfig                |  1 +
>  lib/mbedtls/Kconfig              | 17 +++++++++++++++++
>  lib/mbedtls/Makefile             | 17 ++++++++++-------
>  lib/mbedtls/mbedtls_def_config.h | 41 ++++++++++++++++++++++++++--------------
>  5 files changed, 56 insertions(+), 21 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

thoughts below

> diff --git a/lib/mbedtls/mbedtls_def_config.h b/lib/mbedtls/mbedtls_def_config.h
> @@ -122,7 +144,9 @@
>
>  /* ECDSA */
>  #if CONFIG_IS_ENABLED(ASN1_DECODER)
> +#if CONFIG_IS_ENABLED(ECDSA_MBEDTLS)
>  #define MBEDTLS_ECDSA_C
> +#endif // #if CONFIG_IS_ENABLED(ECDSA_MBEDTLS)
>  #define MBEDTLS_ECP_C
>  #define MBEDTLS_ECDH_C
>  #endif

Please use /* ... */ rather than // here and on the matching #endif
below, like the rest of this file

> diff --git a/lib/mbedtls/mbedtls_def_config.h b/lib/mbedtls/mbedtls_def_config.h
> @@ -62,6 +62,25 @@
>
>  #if CONFIG_IS_ENABLED(MBEDTLS_LIB_X509)
>
> +#if CONFIG_IS_ENABLED(BIGNUM_MBEDTLS)
> +#define MBEDTLS_BIGNUM_C
> +#endif
> +
> +#if CONFIG_IS_ENABLED(ECC_MBEDTLS)
> +#define MBEDTLS_ECP_C

The commit message is very thin for a patch that splits BIGNUM/ECC out
so they can be enabled without TLS, introduces new hidden Kconfig
symbols, moves several object files, and changes lib/ecdsa/Kconfig.
Please expand it to explain the motivation (preparing for ECDSA-verify
via mbedtls) and the structural change.

Regards,
Simon