[U-Boot] [PATCH] Add support W90P710 ARM SoC from Nuvoton

[Jean-Christophe PLAGNIOL-VILLARD]

On 21:45 Tue 20 Jan     , Ben Warren wrote:
> Hi Konstantin,
> 
> On Tue, Jan 20, 2009 at 3:46 AM, Konstantin Vovk <ksl at kslemb.com> wrote:
> 
> > Add support W90P710 ARM SoC from Nuvoton
> > Add W90P1 board based on W90P710
> >
> > Signed-off-by: Konstantin Vovk <ksl at kslemb.com>
> > ---
> >  MAKEALL                                 |    1 +
> >  Makefile                                |    3 +
> >  board/w90p1/Makefile                    |   52 ++++
> >  board/w90p1/config.mk                   |   27 ++
> >  board/w90p1/ide.c                       |  108 ++++++++
> >  board/w90p1/led.c                       |   63 +++++
> >  board/w90p1/lowlevel_init.S             |  130 +++++++++
> >  board/w90p1/nand.c                      |  101 +++++++
> >  board/w90p1/u-boot.lds                  |   69 +++++
> >  board/w90p1/w90p1.c                     |   96 +++++++
> >  cpu/arm720t/cpu.c                       |   46 +++-
> >  cpu/arm720t/interrupts.c                |   88 ++++++-
> >  cpu/arm720t/serial.c                    |  108 +++++++-
> >  cpu/arm720t/start.S                     |   29 ++-
> >  drivers/net/Makefile                    |    1 +
> >  drivers/net/w90p710_eth.c               |  451
> > +++++++++++++++++++++++++++++++
> >  drivers/net/w90p710_eth.h               |  274 +++++++++++++++++++
> >  examples/Makefile                       |    6 +-
> >  include/asm-arm/arch-arm720t/W90P710.h  |  239 ++++++++++++++++
> >  include/asm-arm/arch-arm720t/hardware.h |    5 +-
> >  include/asm-arm/io.h                    |    4 +
> >  include/configs/W90P1.h                 |  237 ++++++++++++++++
> >  include/netdev.h                        |    1 +
> 
> 
> Please break this patch up into logical orthogonal parts.  This is too big
> to expect anybody to wade through.
ping

will send a new version soon?
btw please check the conding style of your patch
you have too long line 80 chars max
a lot's of whitespace when tab will be needed
please add space between |, >>, >, + etc...

Best Regards,
J.