[U-Boot] [PATCH] 2/12 Multiadapter/multibus I2C, common part 2

[ksi at koi8.net]

On Mon, 16 Feb 2009, Wolfgang Denk wrote:

> Dear ksi at koi8.net,
> 
> In message <Pine.LNX.4.64ksi.0902121412060.21067 at home-gw.koi8.net> you wrote:
> > Signed-off-by: Sergey Kubushyn <ksi at koi8.net>
> > ---
> > diff -purN u-boot-i2c.orig/cpu/mpc8xx/video.c u-boot-i2c/cpu/mpc8xx/video.c
> > --- u-boot-i2c.orig/cpu/mpc8xx/video.c	2009-02-12 10:43:41.000000000 -0800
> > +++ u-boot-i2c/cpu/mpc8xx/video.c	2009-02-12 10:46:00.000000000 -0800
> > @@ -809,7 +809,11 @@ static void video_encoder_init (void)
> >  
> >  	/* Initialize the I2C */
> >  	debug ("[VIDEO ENCODER] Initializing I2C bus...\n");
> > +#ifdef CONFIG_NEW_I2C
> > +	i2c_init_all();
> 
> As mentioned before, I think this is a design problem.
> 
> You must not gloablly initialize all I2C busses / adapters.
> 
> You are only permitted to initialize those devices that are actually
> needed by U-Boot itself to perform certain operations, and you are
> supposed to deactivate these after use.

What is wrong with activating ALL i2c adapters? Is there any viable reason
for this?

Then, please point me to a single board that deactivates an I2C adapter. And
please tell me what function one can use to do that. I haven't seen anything
like i2c_deinit() or i2c_disable().

---
******************************************************************
*  KSI at home    KOI8 Net  < >  The impossible we do immediately.  *
*  Las Vegas   NV, USA   < >  Miracles require 24-hour notice.   *
******************************************************************