[U-Boot] pata support in u-boot

[Lv Terry-R65388]

Hi Denk,

	 drivers/block/pata_bfin.c uses sata.h and can use commands in cmd_sata.c.
	 drivers/block/mg_disk.c uses mg_disk.h and can use commands in cmd_mgdisk.c.
	 drivers/block/sil680.c, hm.., I don't know what cmd it uses.

	There's also ATAPI in cmd_ide.c,  which uses code in Pcs440ep.c.

	They are all ATAPI, But use different interface.

	There is no ata common function definitions.

	I just wonder if I should create a new interface, like cmd_pata.c and mxc_pata.h for my ata.

	Actually, sata interface is ok for use in my ata. But it may make customer confused.

	I don't want to add redundant code for ata, so I just ask if there is a better implementation for ata.

	Thanks~~

Yours
Terry
	

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de] 
Sent: 2009年10月21日 17:37
To: Lv Terry-R65388
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] pata support in u-boot

Dear "Lv Terry-R65388",

In message <1AE74F652ECB1440B73DD7C2C20842D19A6462 at zch01exm27.fsl.freescale.net> you wrote:
> 
>     I'm trying to add our ATA driver to u-boot.

Fine.

>     But it seems that now u-boot only supports SATA.

This is not correct. U-Boot also supports ATA/ATAPI, SCSI, USB, PCMCIA, Systemace, ...

>     ATA is mixed with ide in cmd_ide.c.

Indeed.

>     There is no ata common interface in include.

Hm... so include/ata.h is not what you are looking for>

>     Is this suitable?

I'm afraid I don't understand what exactly your problem is.

drivers/block/mg_disk.c, drivers/block/pata_bfin.c or drivers/block/sil680.c seem to show that the current code actually can be used with ATA interfaces.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The following statement is not true.  The previous statement is true.