[U-Boot] [PATCH] davinci timer.c: Remove volatiles and memory mapped structures

Peter Tyser ptyser at xes-inc.com
Mon Oct 26 15:42:56 CET 2009


Hi Nick,

> --- a/cpu/arm926ejs/davinci/timer.c
> +++ b/cpu/arm926ejs/davinci/timer.c
> @@ -1,4 +1,8 @@
>  /*
> + * Copyright (C) 2009 Nick Thompson, GE Fanuc, Ltd. <nick.thompson at gefanuc.com>
> + *
> + * Coding style changes. Use writel and readl for hardware accesses.
> + *
>   * (C) Copyright 2003
>   * Texas Instruments <www.ti.com>
>   *

The change looks good to me, but I don't think your copyright should be
added for such a trivial change.  There are already 6 separate
copyrights for a relatively simple 100 lines of code:)

Best,
Peter



More information about the U-Boot mailing list