[U-Boot] [PATCH] davinci timer.c: Remove volatiles and memory mapped structures

Stefan Roese sr at denx.de
Mon Oct 26 15:48:05 CET 2009


On Monday 26 October 2009 15:42:56 Peter Tyser wrote:
> > +++ b/cpu/arm926ejs/davinci/timer.c
> > @@ -1,4 +1,8 @@
> >  /*
> > + * Copyright (C) 2009 Nick Thompson, GE Fanuc, Ltd.
> > <nick.thompson at gefanuc.com> + *
> > + * Coding style changes. Use writel and readl for hardware accesses.
> > + *
> >   * (C) Copyright 2003
> >   * Texas Instruments <www.ti.com>
> >   *
> 
> The change looks good to me, but I don't think your copyright should be
> added for such a trivial change.  There are already 6 separate
> copyrights for a relatively simple 100 lines of code:)

And you shouldn't add such comments about what you changed into the file 
itself. git will handle those comments.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list