[U-Boot] [PATCH 1/1] at91: Update MEESC board support

[Wolfgang Denk]

Dear Daniel,

In message <20090904211358.GR30118 at game.jcrosoft.org> Jean-Christophe wrote:
> > +#ifdef CONFIG_REVISION_TAG
> > +u32 get_board_rev(void)
> > +{
> > +	return hw_rev | 0x100;
> > +}
> > +#endif
> > +
> > +int misc_init_r(void)
> > +{
> > +#ifdef CONFIG_MACB
> > +	u32 hwaddr_btm;
> > +	u16 hwaddr_top;
> > +	u8 mac[6];
> > +
> > +	/* Set ethernet address */
> > +	if (!eth_getenv_enetaddr("ethaddr", mac)) {
> > +		puts("Missing environment variable 'ethaddr'\n");
> > +        } else {
> > +		hwaddr_btm = mac[0] | mac[1] << 8 | mac[2] << 16 | mac[3] << 24;
> > +		hwaddr_top = mac[4] | mac[5] << 8;
> > +		writel(hwaddr_btm, (void *)(AT91SAM9263_BASE_EMAC + MACB_SA1B));
> > +		writel(hwaddr_top, (void *)(AT91SAM9263_BASE_EMAC + MACB_SA1T));
> nack this will be done when u-boot will need to use the macb

Jean-Christophe means: The Etherent interface must not be always
initialized, but only when it is needed and used within U-Boot itself,
i. e. if U-boot is performing anetwork command. See also item 2 at
http://www.denx.de/wiki/U-Boot/DesignPrinciples  and
http://www.denx.de/wiki/view/DULG/EthernetDoesNotWorkInLinux

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How does a project get to be a year late?      ... One day at a time.