[U-Boot] [RFC][PATCH] NAND boot: MPC8536DS support

[Hu Mingkai-B21284]

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org] 
> Sent: Saturday, September 12, 2009 3:22 AM
> To: Hu Mingkai-B21284
> Cc: Wood Scott-B07421; U-Boot-Denx List
> Subject: Re: [U-Boot] [RFC][PATCH] NAND boot: MPC8536DS support
> 
> 
> On Sep 11, 2009, at 2:17 PM, Kumar Gala
> >
> > Makefile                                       |    1 +
> > board/freescale/mpc8536ds/config.mk            |    7 ++
> > board/freescale/mpc8536ds/tlb.c                |   11 ++
> > cpu/mpc85xx/nand_init.c                        |   73 ++++++++++++++
> 
> how about renaming nand_init.c to cpu_init_nand.c
> 
Ok, I'll fix it.

> 
> > diff --git a/cpu/mpc85xx/nand_init.c b/cpu/mpc85xx/nand_init.c new 
> > file mode 100644 index 0000000..dcbbc8d
> > --- /dev/null
> > +++ b/cpu/mpc85xx/nand_init.c
> > @@ -0,0 +1,73 @@
> > +/*
> > + * Copyright (C) 2009 Freescale Semiconductor, Inc.
> 
> the '(C)' isnt needed.
> 
Ok, thanks.

> 
> > diff --git a/include/configs/MPC8536DS.h 
> b/include/configs/MPC8536DS.h 
> > index 4746e2e..6fab240 100644
> > --- a/include/configs/MPC8536DS.h
> > +++ b/include/configs/MPC8536DS.h
> > @@ -31,6 +31,12 @@
> > #define CONFIG_PHYS_64BIT	1
> > #endif
> >
> > +#ifdef CONFIG_MPC8536DS_NAND
> 
> I think I changed this to make it build.  Once we resolve how 
> we are tweaking mkconfig we can figure this out.
> 
Ok.

> > +#define CONFIG_NAND_U_BOOT		1
> > +#define CONFIG_RAMBOOT_NAND		1
> > +#define CONFIG_RAMBOOT_TEXT_BASE	0xf8f82000
> > +#endif
> > +
> 
> [snip]
> 
> > diff --git a/nand_spl/board/freescale/mpc8536ds/nand_boot.c b/ 
> > nand_spl/board/freescale/mpc8536ds/nand_boot.c
> > new file mode 100644
> > index 0000000..77973d1
> > --- /dev/null
> > +++ b/nand_spl/board/freescale/mpc8536ds/nand_boot.c
> > @@ -0,0 +1,99 @@
> > +/*
> > + * Copyright (C) 2009 Freescale Semiconductor, Inc. All rights
> > reserved.
> 
> 'All rights reserved' isn't acceptable (remove it).  Also get 
> rid of '(C)'
> 
Ok.

> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + *
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General 
> Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + *
> > + */
> [snip]
> 
> 
> Also, we need to add MPC8536DS_NAND to MAKEALL
> 
Ok, thanks.
Mingkai