[U-Boot] [PATCH] OMAP3: Clean up whitespace in mux configs

Tom Tom.Rix at windriver.com
Sun Sep 27 16:25:11 CEST 2009


Olof Johansson wrote:
> On Sun, Sep 27, 2009 at 10:33:58AM +0200, Dirk Behme wrote:
>> Olof Johansson wrote:
>>> Switch from space-based indentation to tab-based in mux configs, as pointed
>>> out by WD at:
>> You have only two options here: Violate space/tab rule or 80 char rule. 
>> We had this discussion with Wolfgang already in the past ;)
> 
> Haha, great.
> 
>> Last time we had:
>>
>> ...
>> [So Jan 25 2009] [18:50:28] <dirk2>	wdenk: Regarding your code comments 
>> in http://lists.denx.de/pipermail/u-boot/2009-January/046090.html:
>> [So Jan 25 2009] [18:51:34] <dirk2>	wdenk: Regarding MUX indent:  
>> normally yes, but ...
>> [So Jan 25 2009] [18:51:59] <wdenk_>	...you have too long lines, then. I 
>> know
>> [So Jan 25 2009] [18:52:49] <dirk2>	wdenk: ... we tried several  
>> formatting options, and jkridner converted one MUX file with beginning  
>> TABs. The result wasn't readable better
>> [So Jan 25 2009] [18:53:34] <wdenk_>	I'll not fight about this one.
>> ...
>>
>> So last time we stayed with space instead of tab and have 80 char fine.
>>
>> If we want to switch now to break 80 chars (and this patch does so) but 
>> have no spaces any more, I'm fine with it. Just want to give some  
>> history.
> 
> Heh.
> 
> Personally I don't mind the occasional breakage of the 80 character
> rule, especially for header files like these that don't affect code
> flow readability.
> 
> But I don't care either way, I just reformatted it on request. If the
> decision goes the other way I can repost the other patch that went on
> top of this so it still applies.
> 

I am ok with it as-is.
If it needs changing, a follow-on is preferred.

Tom

> 
> -Olof
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot



More information about the U-Boot mailing list