[U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

York Sun yorksun at freescale.com
Thu Jul 28 19:46:16 CEST 2011


On Mon, 2011-07-25 at 10:14 +0200, Wolfgang Denk wrote:
> lc_common_dimm_params.c was too verbose and corrupted the boot
> message display like this:
> 
> 	...
> 	DRAM:  Detected UDIMM M2U25664DS88C3G-6K
> 	DDR: 256 MiB (DDR1, 64-bit, CL=2, ECC off)
> 	...
> 
> Turn printf() into debug() so we het the expected output again:
> 
> 	...
> 	DRAM:  256 MiB (DDR1, 64-bit, CL=2, ECC off)
> 	...
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Kumar Gala <galak at kernel.crashing.org>
> 
> ---
>  .../cpu/mpc8xxx/ddr/lc_common_dimm_params.c        |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c b/arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
> index 8132e68..e66cc05 100644
> --- a/arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
> @@ -209,11 +209,11 @@ compute_lowest_common_dimm_parameters(const dimm_params_t *dimm_params,
>  		if (dimm_params[i].n_ranks) {
>  			if (dimm_params[i].registered_dimm) {
>  				temp1 = 1;
> -				printf("Detected RDIMM %s\n",
> +				debug("Detected RDIMM %s\n",
>  					dimm_params[i].mpart);
>  			} else {
>  				temp2 = 1;
> -				printf("Detected UDIMM %s\n",
> +				debug("Detected UDIMM %s\n",
>  					dimm_params[i].mpart);
>  			}
>  		}

NAK.

We need to log module part number for testing and verification,
especially when comparing with different parts. It is also helpful for
support, without asking customers to recompile to enable debugging.

York





More information about the U-Boot mailing list