[U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

[Wolfgang Denk]

Dear York Sun,

In message <1311875176.29459.14.camel at oslab-l1> you wrote:
>
> > -				printf("Detected RDIMM %s\n",
> > +				debug("Detected RDIMM %s\n",
> >  					dimm_params[i].mpart);
> >  			} else {
> >  				temp2 = 1;
> > -				printf("Detected UDIMM %s\n",
> > +				debug("Detected UDIMM %s\n",
> >  					dimm_params[i].mpart);
> >  			}
> >  		}
> 
> NAK.

NAK the NAK.

> We need to log module part number for testing and verification,

debug() is exactly what is intended to be used for testing.

I don't know what exactly you mean by "verification", but I guess that
covers it, too.

Keeping this as prontf() corrupts the format of the boot messages, and
adds to the boot time without real value.

> especially when comparing with different parts. It is also helpful for
> support, without asking customers to recompile to enable debugging.

Then feel free to add a custom command to display this specific
information, but keep it off the regular, unconditionally printed boot
messages.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A Vulcan can  no  sooner  be  disloyal  than  he  can  exist  without
breathing.
	-- Kirk, "The Menagerie", stardate 3012.4