[U-Boot] [PATCH 0/4] Correct some remaining bootm problems

Simon Glass sjg at chromium.org
Thu Jul 11 08:08:07 CEST 2013


The tortuous refactoring of bootm and fit_image_load() has thrown up
four more issues:

- Support for bootm (without arguments) on many OSes is broken since the
OS functions do not handle the PREP stage, which is now required
- In the case of loading a FIT image with a bootm-selected kernel
configuration, this is not used for ramdisk and fdt but must be manually
specified for each.
- The Elf image loader arguments are out by 1
- There is an extra OK message in the case of loading an uncompressed
kernel

This series corrects these problems. Verification was done using some
sandbox tests written for the occassion. These will be sent to the list
during the next merge window (or earlier if anyone wants to try them).

For the record the tests run are:

$ ./test/image/test-fit.py -u b/sandbox/u-boot
FIT Tests
=========
Kernel load
Kernel + FDT load
Kernel + FDT + Ramdisk load
Kernel + FDT + Ramdisk load, Config 2

Tests passed
Caveat: this is only a sanity check - test coverage is poor
$ ./test/image/test-legacy.py -u b/sandbox/u-boot
Legacy Image Tests
==================
Testing 22 image types
['netbsd', 'lynxos', 'rtems', 'ose', 'plan9', 'vxworks', 'qnx', 'integrity']
netbsd: False
netbsd: True
lynxos: False
lynxos: True
rtems: False
rtems: True
ose: False
ose: True
plan9: False
plan9: True
vxworks: False
vxworks: True
qnx: False
qnx: True
integrity: False
integrity: True

Tests passed
Caveat: this is only a sanity check - test coverage is poor


Simon Glass (4):
  bootm: Remove extra OK message
  blackfin: x86: bootm: Handle PREP stage of bootm
  bootm: Use selected configuration for ramdisk and fdt
  bootm: Correct the arguments for the ELF image loader

 arch/blackfin/lib/boot.c |  2 ++
 arch/x86/lib/bootm.c     |  2 ++
 common/cmd_bootm.c       | 20 ++++++++++++++++++--
 common/cmd_elf.c         |  6 +++---
 common/image-fdt.c       |  4 ++--
 common/image-fit.c       |  6 +++++-
 common/image.c           |  4 ++--
 include/image.h          |  7 ++++---
 8 files changed, 38 insertions(+), 13 deletions(-)

-- 
1.8.3



More information about the U-Boot mailing list