[U-Boot] [PATCH] cmd_nvedit.c: setenv_hex must prefix hex with '0x'

Wolfgang Denk wd at denx.de
Sat Oct 5 00:12:30 CEST 2013


Dear Stephen,

In message <524F376C.7070703 at wwwdotorg.org> you wrote:
>
> > I think we should NAK your patch, and suggest to fix the problem by
> > reverting commit 3f83c87 and making "load" default to hex input mode.
> 
> Reverting 3f83c87 would do the opposite of what you want; it'd make
> extload/fatload require 0x prefixes instead of assuming hex. Perhaps
> what you want is a tweak to that patch so that the generic load/ls
> commands always expect a hex value, rather than requiring the 0x prefix?

Well, that should be the result, yes.

You mean the extload/fatload commands have been broken before that?
OK, eventually the bug was introduced before that.  BUt in any case
it's a bug, and should be fixed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quantum Mechanics is God's version of "Trust me."


More information about the U-Boot mailing list