[U-Boot] [PATCH] Revert "am335x_evm.h: If mmcdev and bootpart switch to mmcdev 1, so should mmcroot."

[Robert P. J. Day]

On Tue, 8 Oct 2013, Tom Rini wrote:

> Upon further inspection and review and chatting with kernel folks, what
> happens here is that what mmcblk# a device gets is based on probe order.
> So a system with an SD card inserted with place eMMC on mmcblk1, but
> without an SD card, it will be on mmcblk0.  So U-boot can only provide a
> best guess.  In this case, if no SD card is present, we would want to
> pass mmcblk0p2 still.  If an SD card is present, it woudl be able to
> provide a uEnv.txt that would be loaded (even if the kernel is NOT
> there) which can still update mmcroot variable.
>
> This reverts commit 827512fb1154c05c6eb1e2259e936df55c98a535.
>
> Cc: Robert P. J. Day <rpjday at crashcourse.ca>
> Signed-off-by: Tom Rini <trini at ti.com>
> ---
>  include/configs/am335x_evm.h |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
> index e8e5275..f746e48 100644
> --- a/include/configs/am335x_evm.h
> +++ b/include/configs/am335x_evm.h
> @@ -171,7 +171,6 @@
>  	"run mmcboot;" \
>  	"setenv mmcdev 1; " \
>  	"setenv bootpart 1:2; " \
> -	"setenv mmcroot /dev/mmcblk1p2 ro; " \
>  	"run mmcboot;" \
>  	"run nandboot;"
>
> --
> 1.7.9.5

  are you sure about this? note that, in the above, you've *already*
tried to mmcboot off of device mmcblk0 and, for one reason or another,
that failed. so u-boot then *explicitly* switches to mmc dev 1 with:

  setenv mmcdev 1
  setenv bootpart 1:2

why would it not make sense to also switch mmcroot there as well?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================