[U-Boot] [PATCH v1 3/3] arm, at91: add siemens corvus board

[Andreas Bießmann]

Hello Heiko,

On 10/29/2013 01:41 PM, Heiko Schocher wrote:
> Am 29.10.2013 11:01, schrieb Andreas Bießmann:
>> On 10/28/2013 06:45 AM, Bo Shen wrote:
>>> On 10/22/2013 13:51, Heiko Schocher wrote:
>>>> Signed-off-by: Boris Schmidt<boris.schmidt at siemens.com>
>>>> Reviewed-by: Heiko Schocher<hs at denx.de>
>>>> Cc: Andreas Bießmann<andreas.devel at googlemail.com>
>>>> ---
>>>>    board/siemens/corvus/Makefile |  39 +++++
>>>>    board/siemens/corvus/board.c  | 345
>>>> ++++++++++++++++++++++++++++++++++++++++++
>>>>    boards.cfg                    |   1 +
>>>>    include/configs/corvus.h      | 185 ++++++++++++++++++++++
>>>>    4 files changed, 570 insertions(+)
>>>>    create mode 100644 board/siemens/corvus/Makefile
>>>>    create mode 100644 board/siemens/corvus/board.c
>>>>    create mode 100644 include/configs/corvus.h
>>>>
>>>> diff --git a/board/siemens/corvus/board.c
>>>> b/board/siemens/corvus/board.c
>>>> new file mode 100644
>>>> index 0000000..1940da7
>>>> --- /dev/null
>>>> +++ b/board/siemens/corvus/board.c

<snip>

>>>> +
>>>> +#define CONFIG_AT91_LEGACY
>>>> +#define CONFIG_ATMEL_LEGACY        /* required until (g)pio is
>>>> fixed */
>>
>> The ATMEL_LEGACY is required for dataflash, please consider using the
>> generic mtd sf stuff instead.
> 
> Ok, think about that ...

This legacy stuff is really a mess ... hopefully I get the gpio thing
cleaned up for 2014.01 and completely removed for the follow-up release.

> [...]
>>>> +/* LED */
>>>> +#define CONFIG_AT91_LED
>>>> +#define    CONFIG_RED_LED        AT91_PIN_PD31    /* this is the
>>>> user1 led */
>>>> +#define    CONFIG_GREEN_LED    AT91_PIN_PD0    /* this is the user2
>>>> led */
>>
>> Would you mind to use the generic gpio led stuff instead?
> 
> You mean ./drivers/misc/gpio_led.c ?

I mean the STATUS_LED thing (first part in README.LED). There is the
taskit stamp9g20 board which uses it already (in connection with the
at91 specific colour_LED thing)

<snip>

>>
>> nand read ${laodaddr} kernel ?
>>
>> When using mtdparts in u-boot ... just my 2¢
> 
> You mean:
> nand read ${loadaddr} kernel
> ;-)

I do ;)

By,
Andreas