[U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

Heiko Schocher hs at denx.de
Tue Dec 9 07:17:59 CET 2014


Hello Simon,

Am 09.12.2014 06:31, schrieb Simon Glass:
> Hi,
>
> On Dec 5, 2014 8:32 AM, "Simon Glass" <sjg at chromium.org> wrote:
>>
>> The uclass implements the same operations as the current I2C framework but
>> makes some changes to make it fit driver model better:
>>
>> - Remove the chip address from API calls
>> - Remove the address length from API calls
>> - Remove concept of 'current' I2C bus
>> - Drop all existing init functions
>>
>> Acked-by: Heiko Schocher <hs at denx.de>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> Changes in v5:
>> - Add a function comment for i2c_probe_chip()
>> - Add an assert for offset_len in i2c_setup_offset()
>> - Add more detail to return value comment on get_buf_speed()
>> - Add more detail to return value comment on xfer() method
>> - Fix -INVAL typo
>> - Make i2c_get_bus_speed() independent of i2c_set_bus_speed()
>> - Split DM_I2C_CHIP_RD_ADDRESS into read and write varaints
>> - Update comments in struct i2c_msg to allow buf to be NULL
>> - Use a NULL buffer in i2c_probe_chip()
>
> Any. Ore comments please? Otherwise I will retest and apply this version.

I am fine with it. Thanks for your and Masahiros work!

I hope I find some time to look into using platform data, as I have
no board which uses DT support in U-Boot ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list