[U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

[Masahiro Yamada]

Hi Simon,



On Fri,  5 Dec 2014 08:32:04 -0700
Simon Glass <sjg at chromium.org> wrote:

> +struct dm_i2c_chip {
> +	uint chip_addr;
> +	uint offset_len;
> +	uint flags;
> +#ifdef CONFIG_SANDBOX
> +	struct udevice *emul;
> +#endif
> +};

I do not like this ifdef conditional.
As mentioned in another reply, I suppose we can move to sandbox-i2c.

Anyway, other parts look good enough.


Reviewed-by: Masahiro Yamada <yamada.m at jp.panasonic.com>