[U-Boot] [PATCH V4] OMAP3: Various: Future-proof serial platdata

Adam Ford aford173 at gmail.com
Wed Mar 2 01:05:38 CET 2016


I can only test OMAP3, and I tried to state that in the patch. I grepped
for the platdata structure and not that manu boards aooeared. I didn't want
to just fix the board that affects me, but I didn't want to go beyond the
platform for fear of breaking something and not being able to test it.
On Mar 1, 2016 6:01 PM, "Alexander Graf" <agraf at suse.de> wrote:

>
>
> On 02.03.16 00:23, Adam Ford wrote:
> > A few boards still use ns16550_platdata structures, but assume the
> structure
> > is going to be in a specific order. By explicitly naming each entry,
> > this should also help 'future-proof' in the event the structure changes.
> >
> > Tested on the Logic PD Torpedo + Wireless.
> >
> > I only changed a handful of devices that used the same syntax as the
> Logic
> > board.  Appologies if I missed one or stepped on toes.  Thanks to Derald
> Woods
> > and Alexander Graf.
> >
> > Signed-off-by: Adam Ford <aford173 at gmail.com>
> >
> > V4: Fix subject heading
> >
> > V3: Remove  reg_offset out in all the structs. It was reverted out, and
> and if
> > it did exist, it would get initialized to 0 by default.
> >
> > V2: I hastily copy-pasted the boards without looking at the UART number.
> > This addresses 3 boards that use UART3 and not UART1.
> > ---
> >  board/isee/igep00x0/igep00x0.c      | 6 +++---
> >  board/logicpd/omap3som/omap3logic.c | 6 +++---
> >  board/logicpd/zoom1/zoom1.c         | 6 +++---
> >  board/overo/overo.c                 | 6 +++---
> >  board/quipos/cairo/cairo.c          | 6 +++---
> >  board/ti/beagle/beagle.c            | 6 +++---
> >  board/timll/devkit8000/devkit8000.c | 6 +++---
>
> Looks to me like you didn't catch all boards out there. I don't think it
> makes sense to limit yourself to OMAP3, otherwise different boards (that
> people may not realize are broken that fast) break next time...
>
> arch/arm/cpu/arm926ejs/lpc32xx/devices.c
> arch/arm/cpu/armv7/am33xx/board.c
> arch/arm/mach-tegra/board.c
> board/isee/igep00x0/igep00x0.c
> board/lge/sniper/sniper.c
> board/logicpd/omap3som/omap3logic.c
> board/logicpd/zoom1/zoom1.c
> board/overo/overo.c
> board/quipos/cairo/cairo.c
> board/ti/beagle/beagle.c
> board/timll/devkit8000/devkit8000.c
>
>
> Alex
>


More information about the U-Boot mailing list