[ELDK] [PATCH RFSB V2 2/2] Wrong package extraction for ARM

Stefano Babic sbabic at denx.de
Fri Apr 23 14:42:39 CEST 2010


Detlev Zundel wrote:
> Hi Stefano,
> 

Hi Detlev,

> Ok, I see what is wrong, but I do not like this solution.

Well, no problem, sure there is a better one !

>  On first
> thought, I was thinking of putting it all into gen-pkg-configs.  The
> Makefile really should not care about such inconsitencies of the ELDK -
> this should be isolated in a single spot.

Agree. I made a fast solution. And I have no idea why the arm packages
have a different naming style as other architectures (PowerPC), where
the CROSS_COMPILE suffix is always used.

> 
> On a second thought, we already have such a thing, scripts/eldk-vars.
> Couldn't we put the logic in there (maybe introduce a new variable),
> include (like list-deps) the output of eldk-vars in gen-pkg-configs and
> use that instead of CROSS_COMPILE?

You are right, this is better - moving the suffix into a variable lets
the Makefile neutral for all architecture.

> What do you think of the attached patch?

Agree, much better !

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the eldk mailing list