[ELDK] [PATCH][RFSB] Expand mkfs.jffs2 options

[Detlev Zundel]

Hi Ron,

> This patch will add the options for page size, image padding, clean markers,
> and clean marker size.

Thanks for the patch, which generally looks fine, although I have one
request.

>
> Signed-off-by: Ron Madrid <ron_madrid at sbcglobal.net>
> ---
>  Config.in |   35 +++++++++++++++++++++++++++++++++++
>  Makefile  |   12 ++++++++++++
>  2 files changed, 47 insertions(+), 0 deletions(-)
>
> diff --git a/Config.in b/Config.in
> index 39c965b..7086fb8 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -135,6 +135,41 @@ config JFFS2_ERASE_BLOCKSIZE
>           going to be used on.  On NOR flashes nowadays this is usally
>           greater than 64k, whereas NAND usually has 16k today.
>  
> +config JFFS2_PAGE_SIZE
> +       depends IMAGE_JFFS2
> +       int "Page size to use for image"
> +       default 4096
> +       help
> +         This has to match the page size of the chip the image is going to
> +	 be used on.  For large page NAND flash this is usally 2 KiB and
> +	 for small page NAND FLASH this is usually 512 bytes.

In my opinion, having a default which will not be correct in most cases,
is calling for trouble.  We solved a similar problem for UBI by
defaulting to 0 and including a check with a corresponding error message
in the makefile:

http://git.denx.de/?p=rfsb.git;a=commitdiff;h=d95c7e49b297474f0118bb74523aa9731adcc432

Please change your patch along the same line.

Thanks!
  Detlev

-- 
Thanks so much for Emacs.  What a wondrous system -- one of the real
seven wonders of the world.  Forced to choose between Emacs and, say,
any pyramid, I'd take Emacs.       -- Robert Boyer
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de