[tbot] Why review patches was Re: [DENX] tbot: board hangs if no autoload
sbabic at denx.de
Sat Nov 24 11:57:19 UTC 2018
On 24/11/18 12:46, Pavel Machek wrote:
>>> Anyway, I admit that most time as maintainer is taken by other
>>> activities. First, review. This cannot be automatically done. Then,
>> No, first let tbot do the tasks, which are automatable... !
>> Why reviewing a patch, which does not apply or has checkpatch errors?
> Because it is polite thing to do.
> First you should check if the patch is not doing something completely
> crazy, and design is right. Then come automated check. And then you
> can check rest of the issues.
Agree with you. A patch could fix some important issue, while checkpatch
just check that code styling was applied. A patch could be checkpatch
free, but it is still nonsense.
I think the correct work-flow (and this is what I do) is
> Doing it in different order is just nasty (even through some
> maintainers do it).
I agree with you. IMHO it seems that a maintainer simply ignores a
problem just because a comment was not well formed.
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
More information about the tbot