[tbot] [PATCH] tbot: Provide login_delay parameter for Linux board
sbabic at denx.de
Tue Mar 5 10:16:01 UTC 2019
On 05/03/19 07:29, Harald Seiler wrote:
> Hello Lukasz,
> thank you for your patches! The first one is perfect, I'll apply it asap.
> With the second one I'm not quite happy: I tried to keep the use of timeouts
> to an absolute minimum in tbot to A) make it as fast as possible and B) as
> robust as possible. Timeouts introduce unnecessary delays and can break easily
> if they were not set with enough tolerance (which makes things very sloow).
Well, they should just be configurable and skipped if not required.
> Now I am completely aware of the issue you try to solve here as I have fought
> this exact problem myself in the past. My current best bet for a solution would
> be calling `sysctl kernel.printk 1 1 1 1` at the start of each board session to
> at least keep the kernel from clobbering the console.
This is not a generic solution - it changes the product and it is a fix
just in case output is coming from kernel. There are a lot of cases
where customer's application is just printing to the console at the
start up. A delay lets us to configure it on project basis, and dropping
kernel output does not help.
> But this is of course not implemented yet (mainly because of portability concerns)
> so I am willing to settle with your patch for now.
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
More information about the tbot