[U-Boot-Users] Re: PATCH MPC86xADS and MPC860FADS bug fixes

Nye Liu nyet at mrv.com
Tue Jun 10 00:58:16 CEST 2003


On Wed, Jun 04, 2003 at 12:22:25AM +0200, Wolfgang Denk wrote:
> In message <20030603215854.GA19306 at zumanetworks.com> you wrote:
> > On Tue, Jun 03, 2003 at 11:43:36PM +0200, Wolfgang Denk wrote:
> > > Right. Let's have separate #defines for the  processors  in  case  we
> > > need  to  really  keep them apart (for example, to print a correct id
> > > string), and have some central header file which  contains  something
> > > like
> > > 
> > > 	#if defined(MPC866P) || \
> > > 	    defined(MPC866T) || \
> > > 	    defined(MPC859T) || \
> > > 	    defined(MPC859DSL) || \
> > > 	    defined(MPC852T)
> > > 	#define MPC866_et_al
> > > 	#endif
> > 
> > I'm working on this now, where should i put this header file and what
> > should I name it?
> 
> We   have   similar   styuff   already   (for   CONFIG_TQM8xxL)    in
> "include/common.h", o please add your stuff there, too.

Ok. I've done this, but one unfortunate side effect is that things can't
depend on MPC866_et_al in include/configs/[board].h ... the user will
have to make sure things are correct for a given board. Opinions?

I'm getting close to another patch set, should be done by the end of the
week (pending a few other unresolved issues, which I will summarize when
im done).

also, the MAMR/MBMR -> MxMR patch set I will be putting off indefinitely,
the amount of work involved in changing all the include/configs is pretty
daunting.

warmest regards,
Nye

-- 
Nye Liu
nliu at mrv.com
(818) 772-6235x248

"Who would be stupid enough to quote a fictitious character?"
	-- Don Quixote




More information about the U-Boot mailing list