[U-Boot-Users] Re: [PATCH] 1/4: Board support for Logotronic DL
wd at denx.de
Thu Jun 19 23:56:43 CEST 2003
In message <20030614163045.GB26793 at pengutronix.de> you wrote:
> This is a board support package for the Logotronic DL datalogger board.
Added, but this is the very last time that I accept such a patch:
* CHANGELOG entry missing
* MAINTAINERS entry missing
* Credits entry missing (?)
* single patch split into 9 separate files
* using C++ comments in non-C++ files (include/configs/logodl.h,
* trailing white space (board/logodl/flash.c, board/logodl/logodl.c)
* not compile clean:
logodl.c:41: `MACH_TYPE_LOGODL' undeclared (first use in this function)
Note that the calculation of the required image size in flash has
changed; I recommend to fix your flash driver / linker script.
I will check this in to CVS as is, i. e. the code is NOT COMPILE
CLEAN. Please submit a fix (new patch) ASAP.
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
Don't tell me how hard you work. Tell me how much you get done.
-- James J. Ling
More information about the U-Boot