[U-Boot-Users] Re: [PATCH] 4/4: some general patches

[Wolfgang Denk]

In message <20030614163658.GE26793 at pengutronix.de> you wrote:
> 
> 405gp_enet.c: 
> -------------
> The code shall only be compiled when the user has chosen to use the 4xx
> onchip ethernet device. This is not necessarily true on _all_ 4xx boards
> - CONFIG_MII defines the behaviour.

This is not correct. CONFIG_MII is not used in any 4xx  related  code
except  to enable the MII utils. It has nothing to do with calling or
not calling ppc_4xx_eth_initialize().

Rejected.


> cmd_boot.c:
> -----------
> This code has been in u-boot forever. It was removed by one of my
> cleanup patches some time ago while moving a piece of code to another
> location. It hasn't found it's way back into the code since then.

Added.

> common.h:
> ---------
> Add a generic debugX macro, without changing the existing printk macros,
> as suggested by WD some time ago.

Added.

> eth.c:
> ------
> Compile code only if 4xx CPU _and_ MII was selected.

See above.

Rejected.

> mach-types.h:
> -------------
> Update to latest arm.linux.org.uk master list.

Added.

> README:
> -------
> Add hint for minicom users :-) 

Added.

> tag.h:
> ------
> Put ARM tag handling into separate file. Patch by Holger Schurig.

If this is ARM specific code, I don't want to see it in include/

Please put it in include/asm-arm/ or include/asm-arm/arch/


Rejected.



Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
If I had to live my life again,  I'd  make  the  same  mistakes, only
sooner.                                          -- Tallulah Bankhead