[U-Boot-Users] [PATCH] 2/9: bootp

[Wolfgang Denk]

In message <20030306123101.GO16290 at pengutronix.de> you wrote:
> 
> BOOTP
> =====
>  
> - bug: when accessing data inside a network packet you must use
>   NetCopyIP. When accessing data directly via pointers you can be biten
>   by the processor's 32 bit alignment. 

Thanks for pointing out.

> -#if 0
> -#define	DEBUG		1	/* general debug */
> -#define DEBUG_BOOTP_EXT	1	/* Debug received vendor fields	*/
> -#endif
> +//#define	DEBUG		1	/* general debug */
> +//#define DEBUG_BOOTP_EXT	1	/* Debug received vendor fields	*/
> +#undef  DEBUG
> +#undef  DEBUG_BOOTP_EXT

Rejected.

I will not change 4 lines when the old siolution needs to change just
1 char.

Also, please NEVER use C++ comments in U-Boot code.

>  #ifdef DEBUG_BOOTP_EXT
>  #define debug_ext(fmt,args...)	printf (fmt ,##args)
> @@ -752,8 +753,10 @@
>  	volatile uchar *pkt, *iphdr;
>  	Bootp_t *bp;
>  	int pktlen, iplen, extlen;
> +	IPaddr_t OfferedIP;
...

Added.


Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
I still miss my ex-wife, but my aim is getting better.