[U-Boot-Users] [PATCH] 2/9: bootp

[Robert Schwebel]

On Thu, Mar 06, 2003 at 02:02:17PM +0100, Wolfgang Denk wrote:
> > -#if 0
> > -#define	DEBUG		1	/* general debug */
> > -#define DEBUG_BOOTP_EXT	1	/* Debug received vendor fields	*/
> > -#endif
> > +//#define	DEBUG		1	/* general debug */
> > +//#define DEBUG_BOOTP_EXT	1	/* Debug received vendor fields	*/
> > +#undef  DEBUG
> > +#undef  DEBUG_BOOTP_EXT
> 
> Rejected.
> 
> I will not change 4 lines when the old siolution needs to change just
> 1 char.

We need a unified debug message scheme in u-boot. What we currently have
is a complete mess. 

> Also, please NEVER use C++ comments in U-Boot code.

Well, I see, you are very consequent with your maintainer policy: 

robert at ganymed:~/embedded/cvs/u-boot> find . -name "*.[hc]" | xargs grep "//" | wc -l
   1707

Robert 
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Braunschweiger Str. 79,  31134 Hildesheim, Germany
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
    Phone: +49-5121-28619-0 |  Fax: +49-5121-28619-4