[U-Boot-Users] [PATCH] pass custom data to Linux

[Wolfgang Denk]

In message <fc.004c4e48001e7c8b3b9aca005d326fbc.1e7c9e at rea.de> you wrote:
>
> I'd use the standard tags ATAG_SERIAL and ATAG_REVISION and add
> corresponding setup_*_tag() functions to armlinux.c

I must be missing something. If you are going to crate standard  tags
anyway, why do you need any special code or storage?

> Oh, I wasn't aware that bd_info is going to be obsoleted.
> Well, how about (ab)using the environment variables serial# and
> e.g. revision# for the purpose and leave bd_info alone.

No. Please don't mess with established standard meanings of variables.

Also, I don't see why such a variable would  be  needed.  Envrionment
variables are intended for interaction with the user, but not to hold
information which is used only internally within U-Boot. For example,
guess  why we don't have an environment variable which gives the size
of the flash memory?


Why do you need additional storage for your data? If you can fill  in
the  values  when  setting  up  the  bd_infor structore or when auto-
creating some environment variables you should also be able  to  fill
in  the same values when generating the ATAG_SERIAL and ATAG_REVISION
tags?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Real computer scientists don't comment their  code.  The  identifiers
are so long they can't afford the disk space.