[U-Boot-Users] [PATCH] pass custom data to Linux
Anders Larsen
alarsen at rea.de
Mon Nov 17 12:10:10 CET 2003
Wolfgang Denk <wd at denx.de> schreibt:
>In message <fc.004c4e48001e7c8b3b9aca005d326fbc.1e7c9e at rea.de> you wrote:
>>
>> I'd use the standard tags ATAG_SERIAL and ATAG_REVISION and add
>> corresponding setup_*_tag() functions to armlinux.c
>
>I must be missing something. If you are going to crate standard tags
>anyway, why do you need any special code or storage?
Since the setup_*_tag() functions live in the generic
lib_arm/armlinux.c I need some way to pass the board-specific info.
I thought bd_info were the right place to do this.
>
>No. Please don't mess with established standard meanings of variables.
Roger.
>
>Why do you need additional storage for your data? If you can fill in
>the values when setting up the bd_infor structore or when auto-
>creating some environment variables you should also be able to fill
>in the same values when generating the ATAG_SERIAL and ATAG_REVISION
>tags?
Okay then, how about declaring the functions setup_serial_tag()
and setup_revision_tag() in e.g. include/asm-arm/u-boot-arm.h
and having the board-specific code define them?
lib-arm/armlinux.c would then call them if CONFIG_SERIAL_TAG or
CONFIG_REVISION_TAG, resp, are defined.
Cheers
Anders
More information about the U-Boot
mailing list