[U-Boot-Users] Add support for Picture Elements JSE board
wd at denx.de
Fri Apr 16 01:14:29 CEST 2004
In message <4094-47963 at sneakemail.com> you wrote:
> The attached patch adds to U-Boot support for the Picture Elements
> JSE board, which is PPC405GPr and a few other specific devices. It
> also adds me as the maintainer in the MAINTAINERS file.
To whom it concerns:
I really wish people would start reading my comments to all the
patches I have to add.
Is it really so difficult to understand that I would like to get a
pre-formatted CHANGELOG entry ready for copy & paste?
Is it really so difficult to recognize that many lists like board
names in the Makefile or MAKEALL script etc. are sorted? Then why do
you add your stuff at the end, or at some completely unrelated place?
All of the above :-(
Where is the entry for your board in the MAKEALL script?
In board/jse/Makefile you write:
Copyright 2004 Picutre Elenents, Inc.
Are you really sure about this, or do you want to send a patch? ;-)
diff -Nrud -X exclude.txt u-boot/board/jse/Makefile~ ../u-boot/board/jse/Makefile~
--- u-boot/board/jse/Makefile~ 1969-12-31 16:00:00.000000000 -0800
+++ ../u-boot/board/jse/Makefile~ 2004-03-05 17:05:18.000000000 -0800
Please NEVER submit patches that create garbage files!!!!
Please stick with the indentation rules!!!
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
You see things; and you say ``Why?'' But I dream things that never
were; and I say ``Why not?''
- George Bernard Shaw _Back to Methuselah_ (1921) pt. 1, act 1
More information about the U-Boot