[U-Boot-Users] [PATCH] Cleanup cpu/arm920t

[Wolfgang Denk]

Dear Steven,

in message <4113AB89.9050203 at imc-berlin.de> you wrote:
> 
> Since the cpu/ directory gets clobbered with peripheral driver code I started
> cleaning up cpu/arm920t.
> 
> Idea is that all SoC that are based on ARM9(20T) should share cpu/arm920t.

Thanks for the effort, but I disagree with some parts of the patch.

> * Patch by Steven Scholz, 06 Aug 2004:
>    - Cleanup cpu/arm920t directory by moving peripheral driver code out of
>      cpu/arm920t/ into drivers/ and creating subdirectories cpu/arm920t/imx
>      and cpu/arm920t/s3c24x0 for processor specific code

OK for the general idea, but...

>    - rename cpu/arm920t/usb_ohci.c to drivers/s3c24x0_usb_ohci.c

I disagree with  this.  drivers/  is  for  device  drivers  that  are
_common_  among  architectures.  It makes absolutely no sense to mode
processor  specific  code  like  the  s3c24x0  USB  drivers  to  this
directory.

Please move this into cpu/arm920t/s3c24x0/ instead.

>    - remove cpu/arm920t/usb_ohci.h (duplicate code)

Duplicate to what?

>    - rename cpu/mpc5xxx/usb_ohci.h to drivers/usb_ohci.h so everybody can use
>      it (maybe we can merge cpu/arm920t/usb_ohci.c and cpu/mpc5xxx/usb_ohci.c
>      someday)

Be careful. Do you really think this is a good  idea?  The  52xx  USB
code  suffers from the endinaess problem of the 52xx. I'm not sure if
this is a good base for common code.

Please fix above issues and resubmit.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
No question is too silly to ask. Of course, some  questions  are  too
silly to to answer...  - L. Wall & R. L. Schwartz, _Programming Perl_