[U-Boot-Users] [PATCH] Cleanup cpu/arm920t

[Wolfgang Denk]

In message <41171E78.6070101 at imc-berlin.de> you wrote:
> 
> Accepted. I found some processor  specific driver code in drivers/ (like
> s3c24x0_i2c.c  s3c4510b_eth.c  s3c4510b_eth.h  s3c4510b_uart.c 
> s3c4510b_uart.h) so I thought it becomes "common practice" to put peripheral 

Yes - this has sneaked in because there was no better solution. Given
the planned restructuring this belongs to cpu/XXX/ as well.

> driver code for uart or ethernet (although it might be processor specific) 
> into drivers/.

No, I don't want to have this.  drivers/  is  for  common  (processor
independent) conde.

> > Be careful. Do you really think this is a good  idea?  The  52xx  USB
> > code  suffers from the endinaess problem of the 52xx. I'm not sure if
> > this is a good base for common code.
> 
> The only difference I found is

Agreed - so please use the MPC5200 version as  base,  not  the  other
one.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
Hiring experienced unix people is  like  a  built-in  filter  against
idiots. Hiring experienced NT people provides no such guarantee.
            -- Miguel Cruz in WgL96.349$CC.122704 at typhoon2.ba-dsg.net