[U-Boot-Users] RTC for MPC5200

Reinhard Meyer r.meyer at emk-elektronik.de
Thu Jan 15 11:22:53 CET 2004

Dear Wolfgang,

> In message <033d01c3d6ec$decf7670$6d4ba8c0 at alb.sub.de> you wrote:
> >
> > attached find mpc5200.c to support the MPC5200 RTC
> Added (as rtc/5xxx.c).

I do not understand the logic behind this filename. Are all 5xxx having this
type of RTC?
MGT5100 ? MPC5200 ? MCF5xxx (Coldfire) ??? MPC5500-Series ?
I sincerely doubt that.
So at least a filename like mpc5xxx.c would be better... Currently it
supports only the MPC5200 and nothing else
The RTC support for mpc8xx, for example, is in a file named (correctly)

> > add mpd5200.o to the Makefile in this folder:
> No. This is not acceptable. Will you please  submit  a  proper  patch
> including all these modifications next time? Thanks.

1. these instructions were meant for Victor Wren, who had asked for MPC5200
RTC support
2. the patch for Makefile would not have worked when you rename the file
3. can a patch produce a new file in CVS? If yes, how?

Best regards

More information about the U-Boot mailing list