[U-Boot-Users] [PATCH] ARM720t -- Relocating Exception Vectors

Friedrich, Lars lars.friedrich at wago.com
Wed Jul 7 09:21:08 CEST 2004


> Subject: [U-Boot-Users] [PATCH] ARM720t -- Relocating 
> Exception Vectors
> 
> This patch is for cpu/arm720t/start.S -- The patch relocates the
> exception vectors to RAM address 0x0.

No offense, but this is a bad hack. The copy code belongs from
a 'structured' point of view to where the relocation is done and not
just attached to the end of the source code.
And from an 'optimized code' point of view it belongs there, too, as
_TEXT_BASE is already loaded there into an register for example,
no need to do this multiple times. I don't quite see the necessarity
for a loop, too. There are 7 exception vectors, never more, never less.
The copy procedure can be handled by a single ldmia/stmia pair.

Best regards,
Lars Friedrich

-- 




More information about the U-Boot mailing list