[U-Boot-Users] [PATCH] Part 1 of 2 MPC85XXADS-20040716.patch-1 for TLB/DDR

Wolfgang Denk wd at denx.de
Mon Jul 19 18:15:12 CEST 2004


Dear Jon,

in message <1090252402.10358.21.camel at blarg.somerset.sps.mot.com> you wrote:
> 
> Right.  The first message was rejected as being too large.

Oops? I received it through  the  list,  and  it  made  it  into  the
archives. I don't think it was rejected.

> I broke it into two parts that do the same patch and
> resubmitted it with a -1 and a -2 suffix.

So message 2 + message 3 is the same content as message 1?

> > The subject says "for TLB/DDR".
> 
> Yes, I rewrote the TLB and DDR handling.

...and some other things, whichlook unrelated to me.

> > Changesets that contain different, unrelated modifications  shall  be
> > submitted as SEPARATE patches, one patch per changeset.
> 
> They aren't really unreleated.  For example, there were missing
> TLB entries for PCI address spaces that were added.  The removal
> of the molding options was specifically to clean up the TLBs.

OK, but which of these has anything to do with that:

    * Made MPC8540/8560ADS be 33Mhz PCI by default.
    ...
    * Removed moldy CONFIG_RAM_AS_FLASH, CFG_FLASH_PORT_WIDTH_16
      and CONFIG_L2_INIT_RAM options.
    ...
    * Moved board specific PCI init parts out of CPU directory.

?

> > To make this short: which of your 3 messages shall be added?
> 
> Please add all of them as they all apply and are important.

This makes NO sense to me. If I apply the first patch, the other  two
(part 1 and 2) will not apply any more.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
"Summit meetings tend to be like panda matings. The expectations  are
always high, and the results usually disappointing."   - Robert Orben




More information about the U-Boot mailing list