[U-Boot-Users] [Patch] flashh

[Wolfgang Denk]

In message <20040610142736.GT492 at pengutronix.de> you wrote:
> 
> > > +#define FLASH_28F128K3  0x00A7		/* Intel 28F128K3  ( 128M = 8M x 16 )   */
> > 
> > This is IMHO wrong. The comment a few lines above reads:
> > 	Be careful when adding new type! Odd numbers are "bottom boot sector" types!
> > I don't think this is a bottom boot sector type.
> 
> It's a "all sectors are created equal" type ;) 

That's what I thought, too. So it must have an even ID.

> I'm a little bit confused; I understand these numbers as internal U-Boot
> identifiers, arent' they? The list has duplicate entries. And, according

Yes, they are internal IDs only, but I try to enforce some rules.

> to what you said above, how is this meant: 
> 
> #define FLASH_28F320J3A 0x007C          /* INTEL 28F320J3A ( 32M = 128K x  32)  */
> #define FLASH_28F640J3A 0x007D          /* INTEL 28F640J3A ( 64M = 128K x  64)  */
> #define FLASH_28F128J3A 0x007E          /* INTEL 28F128J3A (128M = 128K x 128)  */
> 
> These are equal sized as well but have ascending numbers. New patch is
> attached. 

Nice catch. This escaped me when it was added - I'm far from being perfect.
Fixed.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
"355/113 -- Not the famous irrational number PI,  but  an  incredible
simulation!"