[U-Boot-Users] [PATCH] Small bug fixes for AT91RM9200DK board

[Wolfgang Denk]

Hello,

in message <JPEIKMACJJPLJFDEAJEMKEGDIBAA.nicolas.lacressonniere at rfo.atmel.com> you wrote:
> 
> - It fixes an Ethernet Initialization problem. Now able to start Linux
> directly from U-Boot without being forced to perform a tffp command before.

Rejected.

This is not a problem in U-Boot, but in your Linux driver.  The  rule
is  that  U-boot  will  initialize  ONLY  that hardware which it uses
itself, and it may even de-initialize the hardare after use. A  Linux
driver  must  not  make  any  assumptions about initialization of the
hardware done or not doen in the boot loader. It  is  resposnible  to
initialize the hardware to a usable state itself.

> - Timings Modifications for SPI DataFlash accesses.
> - It fixes a NandFlash Detection problem

Please split the patch and resubmit only the last 2 items.

In general, please don't combine unrelated modifications in a  single
patch.

Thanks.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
A dog always bit deepest on the veterinary hand.
                                    - Terry Pratchett, _Wyrd Sisters_