[U-Boot-Users] [PATCH] Small bug fixes for AT91RM9200DK board

[Nicolas Lacressonniere]

Hello Wolfgang,

>
> - It fixes an Ethernet Initialization problem. Now able to start Linux
> directly from U-Boot without being forced to perform a tffp command
before.

Rejected.

This is not a problem in U-Boot, but in your Linux driver.  The  rule
is  that  U-boot  will  initialize  ONLY  that hardware which it uses
itself, and it may even de-initialize the hardare after use. A  Linux
driver  must  not  make  any  assumptions about initialization of the
hardware done or not doen in the boot loader. It  is  resposnible  to
initialize the hardware to a usable state itself.

>> OK. We will do it differently.

> - Timings Modifications for SPI DataFlash accesses.
> - It fixes a NandFlash Detection problem

Please split the patch and resubmit only the last 2 items.
>> Done.

In general, please don't combine unrelated modifications in a  single
patch.

Thanks.

Best regards,

Nicolas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_at91rm9200dk.dat
Type: application/octet-stream
Size: 4101 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20040625/cb5be8c6/attachment.obj