[U-Boot-Users] [PATCH] SMC91111 Tx interrupt handling and ethaddr handling
wd at denx.de
Mon May 17 18:11:22 CEST 2004
In message <200405171119.42555.pruhland at microwavedata.com> you wrote:
> 1) proper tx interrupt handling
> - packets must still be freed/releases manually on error
> even with autorelease enabled).
> - Tx int timeout is 100ms according to the manual.
> 2) reverts CTL_DEFAULT back to register default. AUTORELEASE
> is not the default...or this with default at init
> 3) removes 'getenv' and 'setenv' calls from 'smc_get_ethaddr'
> - don't think the ethernet driver should need to know about
> the environment, the data need is already passed to function
> via board info.
> - don't think ethernet driver should change environment, changing
> info is fine.
Please split this into separate patches. I may apply the first 2
parts, but will probably reject the third part. The current behaviour
(as far as I can see) is exactly as documented. I don't see anything
wrong there. YMMV.
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
If you hear an onion ring, answer it.
More information about the U-Boot