[U-Boot-Users] [PATCH] support for CF/IDE on PCMCIA for PXA25X

[Wolfgang Denk]

Dear Christian,

a long, long time ago (Thu, 01 Apr 2004), in message
<1080814283.1850.24.camel at absolute> you wrote:
> 
> Hi, I tried this with some different CFs with FAT file-systems
> on them. There is a README in the patch itself that goes in
> documentation directory.

Your patch to add PCMCIA support for PXA systems  contains  a  pretty
dubious construct:

> +  unsigned int reg_arr[] = {
> +    0x48000028, CFG_MCMEM0_VAL,
> +    0x4800002c, CFG_MCMEM1_VAL,
> +    0x48000030, CFG_MCATT0_VAL,
> +    0x48000034, CFG_MCATT1_VAL,
> +    0x48000038, CFG_MCIO0_VAL,
> +    0x4800003c, CFG_MCIO1_VAL,
...
> +  i = 0;
> +  while (reg_arr[i])
> +    * ( (volatile unsigned int *) reg_arr[i++]) |= reg_arr[i++];

The compiler complains:

	cmd_pcmcia.c:343: warning: operation on `i' may be undefined

and he is obviously right.

Can you please provide a patch to fix this?

Thanks.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How can you tell when sour cream goes bad?