[U-Boot-Users] Patch: allow a fixed port for TFTP

[Jerry Van Baren]

Tolunay Orkun wrote:
> Jerry,
> 
> I have expressed my view that this patch does not address a real 
> problem. You mentioned that all these modifications were necessary 
> because the user were unable to configure their computer (lack of 
> necessary skills or lack of administrative access to configure Windows 
> firewall).
> 
> Nevertheless, if Wolfgang approves it, I would prefer changes to the 
> name of environment variable you are using. When referring to TCP/IP 
> services, we normally associate ports with the port the server component 
> is listening. Thus "tftpport" is not clear enough and may mislead people 
> to the server port. I would prefer more verbose "tftpclientport" or 
> "tftpsrcport". This would allow us to define "tftpserverport" or 
> "tftpdestport" later if necessary as well.
> 
> I do not object to CONFIG_TFTP_PORT, since same variable could be use to 
> enable configurable client and server ports if tftpserverport were to be 
> defined. In fact, I would include support for server port environment 
> support now since it would make your match more useful for a larger 
> audience IMHO.
> 
> Best regards,
> Tolunay
> 
> Jerry Van Baren wrote:
> 
>> Hi Wolfgang, try two on the patch attached.
>>
>> * Patch by Jerry Van Baren 10 January 2005
>>   - Add a configuration option CONFIG_TFTP_PORT and optional env
>>     variable tftpport to force TFTP to use a fixed UDP port.
>>
>> gvb

I kind of like tftpclientport, that is much more descriptive.  Thanks 
for the suggestion.  I've rolled Yet Another Patch[tm].

gvb