[U-Boot-Users] Patch: allow a fixed port for TFTP (take 3)
listmember at orkun.us
Wed Jan 12 00:47:11 CET 2005
Wolfgang Denk wrote:
> In message <41E3ECBA.5030802 at smiths-aerospace.com> you wrote:
>>Hi Wolfgang, try three on the patch attached. The change here is to
>>rename the env variable per Tolunay Orkun's recommendation.
> I reject this because such a long variable name seems unacceptable to
> me. Don't make life unnecessarily hard to your users. Use a short
> name. How about "tftpport"?
Wolfgang, "tftpport" is what he has done previously.
It is more appropriate and customary for "tftpport" to refer to the
server port (i.e. reference to a port without a qualification of
client/server, source/destination etc). This patch on the other hand is
leaving the server port as is (well known port) and modifying the
normally dynamic source (client) port to a fixed value via environment.
I think, using "tftpport" would be a poor choice.
I will pledge for clarity over 6 more bytes in environment which most
boards will not define anyway. If that is not reasonable, please allow
for "tftpsrcport" or "tftpcport".
I actually want to provide a complimentary patch over this one to make
the tftp server port configurable which the environment variable can be
appropriately named as one of "tftpserverport", "tftpdestport" or
"tftpsport". I also want to use the same CONFIG_TFTP_PORT variable to
enable both environment variables unless you object in which case naming
the config variables as CONFIG_TFTP_CLIENT_PORT and
CONFIG_TFTP_SERVER_PORT is probably better.
More information about the U-Boot