[U-Boot-Users] Re: [patch]:malta support added for U-boot

[Wolfgang Denk]

In message <20050127162253.25468.qmail at web54410.mail.yahoo.com> you wrote:
>
> Attached are the files required and the text of the 
> changes. The patch contains - 
> 1) Malta U-boot support till serial prompt comes up.
> all the u-boot commands on serial prompt works.

Thanks a lot for this. I highly appreciate your effort.

> 2) Malta has specific requirement of downloading the
> u-boot.fl file, so go.pl included in the top u-boot
> directory should be used to download the srec file
> onto malta board.

Please try to keep MALTA specific stuff inthe MALTA board directory.

> 3) While builiding the code I removed some other
> boards from the Makefile, but right now don't have
> time to add them back. Excuse me for this. But the
> MAKEALL script works.

Actually yor patch would cripple all files it touches by throwing out
code that is needed for other boards. I cannot retrace why  you  made
most  changes  (like removing Copyright entries from rtc.c ?), but in
the current state this patch is useless - I cannot apply  it  to  the
source tree without corrupting it.

Please clean it up such that it has minimal impact  on  other  boards
and resubmit.

> 4) The code was compiled under sde.

What's "sde" ?

> If the patch needs some modifications I can
> incorporate that in few days.

Yes,  the  patch  needs  some  modifications:  a  major  cleanup  and
overhaul. Sorry.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Imagination is more important than knowledge.      -- Albert Einstein