[U-Boot-Users] pci_hose_read_config_byte() definition puzzles

[Wolfgang Denk]

In message <20050602054723.86671.qmail at web15906.mail.cnb.yahoo.com> you wrote:
>
> > A dummy prototype referenced nowhere in the source
> > code?
> 
> Yea. I guess there is a mistake. pci_cfgfunc_nothing()
> should be pci_cfgfunc_do_nothing() which is defined
> in drivers/pci.c. But pci_cfgfunc_do_nothing() is a
> dummy one which isn't used at all. Should we remove 
> them or just fix it?

Fix it (having a look at the corresponding Linux code might help).

> > > extern pci_dev_t pci_find_class(int wanted_class, 
> > > int wanted_sub_code, int wanted_prog_if, int
> > index);
> > 
> > A dummy prototype referenced nowhere in the active
> > source code?
> 
> Not quite sure this one:-). grep told me it was used
> but where was it's body?!!

It seems it gets used only in code which is deactivated by a "#if  0"
or not compiled in any used configuration.

Again, just grepping for somthing is not enough. You have to read the
code.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The world is no nursery.                              - Sigmund Freud