[U-Boot-Users] [PATCH] revised word alignment fixes for word aligned NS16550 UART

jean-paul.saman at philips.com jean-paul.saman at philips.com
Tue Mar 1 17:10:33 CET 2005

The patch is created against current CVS 2005 march 1st and fixes problems 

for boards that only have word access to the NS16550 UART.

From: Jean-Paul Saman
Date: 23-02-2005
Subject: [PATCH] word alignment fixes for word aligned NS16550 UART 

* Patch by Jean-Paul Saman, 23 Feb 2005

- include/ns16550.h 
Fixes alignement bug with UART that only supports word aligned access:
removed "__attribute__ ((packed));" for "(CFG_NS16550_REG_SIZE == 4)" 
GCC generates bytes access when it encounters the packed attribute 
regardless if the struct is already word aligned for a platform. 
Peripherals that can only handle word aligned access won't work properly 
when accessed with byte access. The struct NS16550 is already word aligned 
for REG_SIZE = 4, so there is no need to packed the struct in that case.

Kind greetings,

Jean-Paul Saman

Philips Semiconductors CTO/RTG
Philips HighTech Campus, building WDB 3.29
Professor van den Holstlaan 4
5655 AA Eindhoven
tel: +31 (0)40 27 45131
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-20050301-ns16550-jpsaman-1.patch
Type: application/octet-stream
Size: 1414 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050301/1a70f188/attachment.obj 

More information about the U-Boot mailing list